afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] dw_styles2009-04-25 05:20 am

Core1 ported styles reading page problems

So in the latest code push, we fixed an issue where the "friends" terminology was still hanging around, and replaced it with "read". This caused the logic on the reading pages of some ported styles to not work right.

The most common manifestation of this is that usernames of entry posters on the readpage and /network disappear, making the page look like your recent entries page.

Quick fix, look for:

$p.view == "friends".

It may show up also in other forms such as $.view == "friends", or also $p.view != "friends", etc)

Replace that with the relevant line below, including parentheses:

($p.view == "read" or $p.view == "network")
($.view == "read" or $.view == "network")
($p.view != "read" and $p.view != "network")

PS. We also fixed a bunch of Transmogrified issues, including putting the most basic wizard options in -- num_items_reading, num_items_recent, use_journalstyle_entry_page- -, and the huge whitespace after every username in a comment. And [personal profile] av8rmike has been awesome at polishing away some rough spots in the Negatives CSS.

As always, we're working on fixing bugs and improving the style system. No new features until we've reached Open Beta (seven days away!), but once we're safely into Open Beta, we can focus on implementing richer features. Custom text modules come to mind (though we're not stopping there)!

ETA If your style has both, make sure that you edit both your layout layer, and your theme layer
ETA: 2010-09-07: added network
oxoniensis: close-up of a clock face (world: expanding into infinite nothing)

[personal profile] oxoniensis 2009-04-24 09:35 pm (UTC)(link)
Yay, thank you!
winterfish: a red slide in  a green field with a lake and mountains behind (pushing daisies: yay!)

[personal profile] winterfish 2009-04-24 09:35 pm (UTC)(link)
Yay! Thank you so much. :)
ashtoreth: (Default)

[personal profile] ashtoreth 2009-04-24 09:40 pm (UTC)(link)
Thank you!
trobadora: (Default)

[personal profile] trobadora 2009-04-24 09:46 pm (UTC)(link)
Aha! Thanks muchly. :-)
naraht: (Default)

[personal profile] naraht 2009-04-24 09:47 pm (UTC)(link)
It worked, thanks!
turlough: Frank Iero asking a question, art by theopteryx ((mcr art) excuse me?)

[personal profile] turlough 2009-04-24 09:50 pm (UTC)(link)
We also fixed a bunch of Transmogrified issues [...] the huge whitespace after every username in a comment

It looks like it's still there to me, in this entry for example. I haven't done anything to the s2 code at all and emptying the browser cache doesn't get rid of it. (I'm using Firefox 3.0.8 on Mac OSX 10.4.11)

(no subject)

[personal profile] turlough - 2009-04-24 21:59 (UTC) - Expand

(no subject)

[personal profile] turlough - 2009-04-24 22:09 (UTC) - Expand
boji: (Default)

[personal profile] boji 2009-04-24 09:51 pm (UTC)(link)
Custom text modules come to mind

Is that when we'll be able to change the font choice for text on our dwj's?

Yes, I am a little tech impaired.

(no subject)

[personal profile] boji - 2009-04-24 21:57 (UTC) - Expand

drug Cialis tablets Of470K9

(Anonymous) - 2009-05-23 00:10 (UTC) - Expand
cheyinka: A sketch of a Metroid (Default)

[personal profile] cheyinka 2009-04-24 10:10 pm (UTC)(link)

I got the usernames to show up again on my reading page (after doing a bit more updating because I had figured "well as long as it still works I don't need to keep up with the changes", oops!) and now the comment links don't show up.

on my journal page:

on my reading page:

cheyinka: a spoof of an iPod ad, featuring a Metroid with iPod earbuds pressed against each of its 3 internal organs (iMetroid iScree)


[personal profile] cheyinka 2009-04-24 10:18 pm (UTC)(link)
Fixed, sorry - what I'd done is make two replacements too many. All better!
aurora: (Heroes SylarMohinder Heart)

[personal profile] aurora 2009-04-24 10:23 pm (UTC)(link)
It worked! Thanks so much!!
zulu: Omar Epps, looking awesome (house - epps)

[personal profile] zulu 2009-04-24 10:26 pm (UTC)(link)
Excellent, thanks, everything's back as it should be.
tyffi: (ale squee)

[personal profile] tyffi 2009-04-24 10:27 pm (UTC)(link)
Whee! Thanks so much!
cereta: Paper Bage Princess, heading off into the sunset alone (Paper Bag Princess)

[personal profile] cereta 2009-04-24 11:11 pm (UTC)(link)
Thank you, thank you, thank you for the Transmogrified fix! Yay!
zoniduck: (Default)

[personal profile] zoniduck 2009-04-24 11:43 pm (UTC)(link)
Fixed! Thank you!

[personal profile] ames 2009-04-24 11:47 pm (UTC)(link)
Excellent, thank you! This was easy as pie.

[personal profile] foxfinial 2009-04-24 11:48 pm (UTC)(link)
anagrrl: (Serious!glasses)

[personal profile] anagrrl 2009-04-25 12:08 am (UTC)(link)
I'm using a Core2 custom layer (based on Mixit), and although some of the usernames are showing up on my reading page, others are not. Specifically, usernames show up when someone has posted to a comm I'm reading, but the comm name doesn't show up. And, usernames don't show up on posts from personal journals. Any suggestions would be great!

(no subject)

[personal profile] anagrrl - 2009-04-25 12:27 (UTC) - Expand

(no subject)

[personal profile] ct - 2009-04-25 15:46 (UTC) - Expand
elizaria: (maxx- yumm)

[personal profile] elizaria 2009-04-25 12:53 am (UTC)(link)
thank you, super easy to fix this suddenly :D
musesfool: the middleman and wendy watson (let the loving come back to me)

[personal profile] musesfool 2009-04-25 12:58 am (UTC)(link)
htbthomas: (Thanks)

[personal profile] htbthomas 2009-04-25 01:18 am (UTC)(link)
Thanks for putting this out here so quickly!
artisan447: (Default)

[personal profile] artisan447 2009-04-25 01:49 am (UTC)(link)
A couple of minor faults in the greater scheme of things, but you'd probably rather know than not...

See an OpenID user error here (from Jaybee65 re trying to type in text box):

And also, another OpenID thing where user icons are showing up under the user subject, rather than to the right where normal icons sit. You can see it in the comments here:

[identity profile] 2009-04-25 02:08 am (UTC)(link)
I did some experimenting, and the problem with being able to see the entire comment input text box seems to happen when I have the site scheme set to Celerity. I do not have this problem when it's set to Tropospherical Red. (I haven't tried the others.)

(no subject)

[identity profile] - 2009-04-25 04:48 (UTC) - Expand
torachan: (Default)

[personal profile] torachan 2009-04-25 02:10 am (UTC)(link)
Ooh, thanks. I just noticed my flist was not displying the names and couldn't figure out what had happened.

By the way, what style is the one this comm is using? Because a lot of people have it and it has a glitch where part of the text box (not the inline commenter, but the main comment page if you do more options or click the link from email) runs under the sidebar. It's been bugging me a lot because when I reply to people I can't see what I'm typing, but I was lazy and wasn't sure where to report it, so I didn't. (But I'm here now and you're talking about style bugs, so...)

(no subject)

[personal profile] torachan - 2009-04-25 03:23 (UTC) - Expand

(no subject)

[personal profile] torachan - 2009-04-25 03:29 (UTC) - Expand

(no subject)

[personal profile] torachan - 2009-04-25 04:02 (UTC) - Expand

(no subject)

[personal profile] torachan - 2009-04-25 04:25 (UTC) - Expand
melannen: Commander Valentine of Alpha Squad Seven, a red-haired female Nick Fury in space, smoking contemplatively (Default)

[personal profile] melannen 2009-04-25 03:10 am (UTC)(link)
Yay, thank you!

(Question: is using custom friendssubscription colors going to become an option in any of the standard DW styles anytime soon?)
entrenous88: (Default)

[personal profile] entrenous88 2009-04-25 04:06 am (UTC)(link)
Ack, for some reason I can't get this to work. I'm supposed to be changing it in the "Customize Style" --> "Edit your layout layer" page, right?

It may just be I'm missing something super basic. Will try again in the AM.
dingsi: The Corinthian smoking a cigarette. He looks down thoughtfully and breathes the smoke out of his nose. (Cori2 - default)

[personal profile] dingsi 2009-04-25 04:21 am (UTC)(link)
I had the same problem, then realized I had to make the changes in the layout layer and the theme layer... (My apologies if I've just said something you already figured out for yourself in the meantime.)

(no subject)

[personal profile] entrenous88 - 2009-04-25 04:35 (UTC) - Expand


(Anonymous) - 2009-05-15 01:46 (UTC) - Expand


(Anonymous) - 2009-05-16 16:27 (UTC) - Expand
kunzite: (Default)

[personal profile] kunzite 2009-04-25 04:36 am (UTC)(link)
seems the default tracking images used when AJAX does its fancy work is wrong.
tracking replaces it with instead of .
untracking replaces it with instead of .
karen2205: Me with proper sized mug of coffee (Default)

[personal profile] karen2205 2009-04-25 01:29 pm (UTC)(link)
Repeating a comment I left on [site community profile] dw_maintenance, in case this is a better place for it.

I was using Zesty White (which I believe is Core 2) and following the code change usernames were displaying fine, but the names of communities weren't displaying so instead of saying [staff profile] mark wrote in [site community profile] dw_maintenance, it just said "[staff profile] mark wrote under $list of tags" making it appear as if entries in communities were actually entries in personal journals, which is a bit confusing.

I have swapped to using transmogrified because I couldn't work out how to implement the change you're suggesting above - I could get to the advanced customisation area, but couldn't see any layout code that I could alter which I suspect is because Zesty White is a Core 2 style.

Page 1 of 2

<< [1] [2] >>