afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] dw_styles2009-03-30 11:53 pm

Updates, updates, updates (we have a style!)

Hi! So with the latest code push, styles has gotten some much needed love.

The most visible change is that we have a style! Negatives was written by [personal profile] phoenix for the 2005 LiveJournal styles contest, and was rewritten by the styles team to be compatible with core2, which means it supports "newer" features (expand, tracking, tags, proper alt text for userpics) for free!

Other things that went out:

  • everyone who was using the default style has been moved over to Negatives. This does not mean that Negatives is going to be the default style! We'll revisit that question once we have more styles on the site.

  • bullet point above fixed the problem with the customize page

  • renamed the sidebar variables to use "modules" in their names -- this may break existing layouts which were ported to core2

  • tweaks to core, to solve some issues that were reported to us from the first run (closing tags, etc). Note that this does not fix everything -- we still have a few issues reported to us that we are looking at.

  • tag cloud module

  • some additional rel links (next, prev, help), for accessibility and people with browsers smart enough to do something with these

  • ETA: we've made the items in the entry management links (track, memory, etc) a <ul> (thanks, [personal profile] janinedog for reminding us!)


We're still working on:

  • more styles (of course!)

  • documentation, guides

  • exposing variables through the wizard

  • and an idea for improving the wizard. Details once we have something we can show you!




Still have no wizard, but we're getting close to the point where we can open up. The main problem with the wizard is that it establishes expectations that it's safe to play with the variables and we're not ready for that. Almost, but not yet.

We have one more major change in mind, to make the module names easier to read/write. They're currently "primary", "secondary", "tertiary", "quarternary". Or is it "quaternary"? I don't know, and I've been working with this code for ages. So we're thinking of renaming them to primary module_group_one, module_group_two, module_group_three... and so on. Easier to read, easier to remember, easier to expand upon.

(ETA I mashed together combine two separate things that Abby and I were talking about. To clarify:

Previously, module groups in S2 were named module_group_primary(), module_group_secondary(). In HTML, these were laid out in #primary, #secondary, #tertiary. #primary contained the entries, #secondary contained module_group_primary(), and so on, and it was confusing.

So we're renaming module_group_primary() to module_group_one(), etc. HTML layout will continue to use #primary to indicate the main content.)

Please report any new issues through your usual bug-reporting channels. If you don't know what those are, feel free to comment to this entry! But first, check the list of open styles-related bugs and the list of all styles-related bugs. (Note: we still have some issues reported through comments that aren't in bugzilla. We'll be going through those and opening up bugs as appropriate, soon).

Currently known issues:

janinedog: (Default)

[personal profile] janinedog 2009-03-30 06:26 pm (UTC)(link)
Another change I noticed: it seems you guys wrapped the entry link bar icons in a <ul>. I noticed because mine suddenly had bullet points and were vertical on the screen. :) So people may need to adjust their CSS to account for this.

As for the module names, I think you should make the first one module_group_one, not primary. More consistent!
foxfirefey: A fox colored like flame over an ornately framed globe (Default)

[personal profile] foxfirefey 2009-03-30 06:57 pm (UTC)(link)
This might not be a bug, but one thing the new style doesn't have is a <title>, and I think it should, unless for some reason that was done on purpose?

[personal profile] rho 2009-03-30 08:37 pm (UTC)(link)
Am too lazy to zilla these, so you get them here.

1. Calendar needs to be changed to archive.
2. The comment links need to be brought inside the «» go.bml links.
forthwritten: glowing sonic screwdriver from Doctor Who.  Text: "Alien tech" with an arrow pointing to the sonic screwdriver  (alien tech)

[personal profile] forthwritten 2009-03-30 11:11 pm (UTC)(link)
This is really cool, go team!

Couple of issues:

- I'm finding the bottom links (to comment, edit entry, edit tags, etc) difficult to read. This is probably a combination of small netbook screen and my shitty eyesight, if there is an accessibility issue there it may affect whether or not you run with this as a default style.

- module_group_one, module_group_two etc sounds more intuitive and easier to remember.
aveleh: Close up picture of a vibrantly coloured lime (Default)

[personal profile] aveleh 2009-03-31 03:12 am (UTC)(link)
*nods* Yes, I'm trying to put everything that makes sense to be in a list in a list (I'm behaving, I personally like entries and comments to be in lists too!) Once it's finalized, I want a "base CSS" type thing that's easy for people to pull in, which will make it easy to be lazy and still display those lists inline.

As far as the modules, pretend you didn't see that (and continue to pretend until fu gets a chance to edit the entry); it got mashed up in translation. The modules will definitely be a module_group_one, module_group_two type sequence. It's the CSS that will be changed to something like "primary" for the body and "groupA, groupB, groupC" for the sidebar type areas, because (1) it's too confusing to put the secondary module in the tertiary div, and (2) most of those don't have priority, only ordering, but I want to make it easier for new-to-CSS people to understand that the primary div should have primary information, such as entries.
aveleh: Close up picture of a vibrantly coloured lime (Default)

[personal profile] aveleh 2009-03-31 03:14 am (UTC)(link)
Nope, not missed on purpose. And noted; thanks!
aveleh: Close up picture of a vibrantly coloured lime (Default)

[personal profile] aveleh 2009-03-31 03:24 am (UTC)(link)
Yeah, I'm totally happy to move stuff into bugzilla as necessary <3

1. And Journal should be Recent Entries. Somehow we didn't take out the style overrides there. (All text can be overridden in the wizard - or at worst by using the theme layer- but defaults for official styles should be the site defaults.)

2. *nods* A couple of things to clean up there, including making those links actually called previous/next entry as to not be confusing.

Thanks!
aveleh: Close up picture of a vibrantly coloured lime (Default)

[personal profile] aveleh 2009-03-31 03:29 am (UTC)(link)
The CSS is still a work in progress; so it used a particular default. We'll definitely check on sizes before they get finalized. In the meantime, are you okay with it, or was basic core2 easier for you to read and do you need instructions for how to make that your default? (Aka, we want to make it easier for everything to be accessible, but we know it won't be yet. So do let me/us know if there's anything we can do to make your experience accessible even if the style itself isn't going to be accessible asap.)

Yes, the module notes were a mashed-in-afuleh-translation and they will be called something more sequence-y :)
aveleh: Close up picture of a vibrantly coloured lime (Default)

[personal profile] aveleh 2009-03-31 03:30 am (UTC)(link)
Also, eeek, THANK YOU <3
forthwritten: glowing sonic screwdriver from Doctor Who.  Text: "Alien tech" with an arrow pointing to the sonic screwdriver  (alien tech)

[personal profile] forthwritten 2009-03-31 09:10 am (UTC)(link)
I'll see how this looks on my main monitor, but if there's still an issue I'd really appreciate being able to switch back to core2. Do you want screenshots or anything (not sure how useful they'd be, but at least it might identify whether it's a screen size issue)? I'm using a 10.2" screen, 1024 x 600 resolution. I think it's the combination of small font, light grey on black, spacing and jagged edges that are making it difficult for me to read.
forthwritten: glowing sonic screwdriver from Doctor Who.  Text: "Alien tech" with an arrow pointing to the sonic screwdriver  (alien tech)

[personal profile] forthwritten 2009-03-31 09:38 am (UTC)(link)
Screenshot. I should have got one that showed some numbers because those are particularly hard to read, but hope this helps anyway.

Thanks for letting me know how to change it back to core2.
dani_the_girl: (Default)

[personal profile] dani_the_girl 2009-03-31 03:50 pm (UTC)(link)
I would suggest that the tag cloud module probably shouldn't display tags with zero uses. Also, thank you for fixing the day page :) I'll continue to poke and let you know if I see anything else...
branchandroot: oak against sky (Default)

[personal profile] branchandroot 2009-03-31 03:54 pm (UTC)(link)
Had a thought. Would it make sense to make the link for "x comments" go to some kind of anchor for the comments rather than the permalink? Considering that the default appears to be that the entry header goes to the permalink (which I think is brilliant and wonderful), and therefore there's already a link for that. A way to go directly to the comments/bottom-of-entry, also, seems like a really handy thing to have, and linking it to the "x comments" seems like the most intuitive thing.
ext_312: comic!Gerard & Frank (sad)

[identity profile] turloughishere.livejournal.com 2009-03-31 04:29 pm (UTC)(link)
When you use larger font sizes the page summary moves to the bottom of the page. That isn't intentional, right?
av8rmike: Futurama's Bender in Jeffries tube, text: I'm done reconfoobling the energymotron (Default)

[personal profile] av8rmike 2009-03-31 07:22 pm (UTC)(link)
Not as such-- that's a function of floated content. If there isn't enough horizontal space for a float, it "sinks" to the bottom of its container. I think I know a few CSS tricks to keep that from happening.
dani_the_girl: (Default)

[personal profile] dani_the_girl 2009-03-31 09:43 pm (UTC)(link)
Re CSS for comments (you may well know this, in which case disregard...)

1) There's no css class for each comment - there's an *id*, but they could use a class too so I can apply things to each comment
2) There's no way to uniquely identify the header of the comment - that div doesn't have a class either.
3) The poster is wrapped in a span tag, but the IP address, multiform and date aren't, giving no way to reposition them on the page
domtheknight: espresso machine brewing into little white mugs (Default)

[personal profile] domtheknight 2009-04-01 02:16 am (UTC)(link)
A couple things in case no one has reported them yet (definitely didn't see in zilla) - the summary links on the sidebar don't actually move the page to the referenced post, and on some posts (like this one) I'm seeing weird things with comment threads not lining up. On posts in my own journal so far they appear to line up where I think they should.
exor674: Computer Science is my girlfriend (Default)

[personal profile] exor674 2009-04-01 03:53 am (UTC)(link)
http://dw-news.dreamwidth.org/2421.html?thread=39797#t39797

"ext_2915" links to the thread and squeaky.insanejournal.com links to an invalid profile (which for some remaps to the current user?).
ext_312: thinking!Frank (thinky thoughs)

[identity profile] turloughishere.livejournal.com 2009-04-01 02:52 pm (UTC)(link)
I definitely agree with # 3, the multiform is something I always want to reposition.
ext_312: yay!Gerard (yay!)

[identity profile] turloughishere.livejournal.com 2009-04-01 02:53 pm (UTC)(link)
Aha. Good to hear that there's a fix already!
ext_312: yay!Gerard (yay!)

[identity profile] turloughishere.livejournal.com 2009-04-01 02:54 pm (UTC)(link)
I spotted that in the changelog feed when I looked at my flist today, yay!

Page 1 of 4