Core2 Release Candidate!

[aveleh]

Mark just pushed a whole bunch of changes. So, some notes:

• A reminder: If you're planning on using any layers written for other LiveJournal-based sites, and you're not planning on converting it to use any of core2's awesome new functionality, you may find it easier to have it inherit from core1.


• There's a number of big changes to core2 and negatives, so if you've edited any core2 layers, your style may break. Bookmark the Select Journal Style page and dw_styles so that you can get yourself sorted.


• This version of core2 should be considered our release candidate. (Yay!) We don't expect to rename any more functions or properties (you have to stop somewhere, zorkian tells me). That is, we've moved from the "overhaul" stage, to the "patching" stage.


• This version of Negatives continued with the overhaul, so there's some funky CSS going on. We figured it was a good opportunity to get it out, and to get people working. If you notice something wrong, leave a comment, and we'll confirm and move it into our ticket tracker. If you know how to fix it, leave a patch! Either way, thank you!


• After the patching stage, there will be lots of opportunity to increase the functionality and options available. If you're a dev or a wanna-be-dev, now's a good time to get thinking!

• UserLite::print_linkbar() no longer exists. This has been replaced by UserLite::print_interaction_links()


• EntryLite::print_linkbar() no longer exists. This has been replaced by EntryLite::print_management_links()


• EntryLite::print_item_linkbar() no longer exists. This has been replaced by EntryLite::print_interaction_links()


• print_entry_poster(EntryLite e) no longer exists. Now implemented as EntryLite::print_poster()


• ReplyPage::print_comment has been added in order to implement ReplyPage::print_body in a more consistent manner.


• property string[] show_sidebar_group, property bool show_sidebar_recent, property bool show_sidebar_reading, property bool show_sidebar_entry, and property bool show_sidebar_others have all been removed. Ticket 836 proposes that it is instead implemented for individual modules.


• property string[][] module_group_one, property string[][] module_group_two, property string[][] module_group_three, property string[][] module_group_four,Page::print_module_group_one, Page::print_module_group_two, Page::print_module_group_three, and Page::print_module_group_four removed. have been removed. These were replaced by various new properties and functions for module implementation. (Tutorial coming soon!)


• function print_custom_control_strip_css() has been removed a little early because of Ticket 630. Please let me know if causes any problems; I've already opened up a ticket to investigate.

Lazy diff format display of renamed properties:
-property Color entry_link_color { des = "Entry link color"; }
-property Color entry_link_color_hover { des = "Entry link color on hover"; }
-property Color entry_link_color_visited { des = "Entry link color when visited"; }
-property Color entry_border { des = "Color of entry border and comment background"; }
-property Color entry_background { des = "Entry background color"; }
-property Color comments_link_color { des="Color of comment section links and text"; }
-property Color comments_link_color_hover { des="Color of comment section links when hovered"; }
-property Color metadata_color { des= "Color of metadata (mood/music) text"; }

+property Color color_entry_link { des = "Entry link color"; }
+property Color color_entry_link_active { des = "Entry active link color"; }
+property Color color_entry_link_hover { des = "Entry hover link color"; }
+property Color color_entry_link_visited { des = "Entry visited link color"; }
+property Color color_entry_border { des = "Entry border color"; }
+property Color color_entry_background { des = "Entry background color"; }
+property Color color_entry_text { des = "Entry foreground color"; }
+property Color color_entry_title { des = "Entry title color"; }
+property Color color_entry_interaction_links { des = "Color of interaction links and text"; }

+property Color color_page_background { des = "Page background color"; }
+property Color color_page_text { des = "Page foreground/text color"; }
+property Color color_page_link { des = "Page link color"; }
+property Color color_page_link_active { des = "Page active link color"; }
+property Color color_page_link_hover { des = "Page hover link color"; }
+property Color color_page_link_visited { des = "Page visited link color"; }
+property Color color_page_title { des = "Page title color"; }
+
+property Color color_module_background { des = "Module background color"; }
+property Color color_module_text { des = "Module foreground color"; }
+property Color color_module_border { des = "Module border color"; }
+property Color color_module_link { des = "Module link color"; }
+property Color color_module_link_active { des = "Module active link color"; }
+property Color color_module_link_hover { des = "Module hover link color"; }
+property Color color_module_link_visited { des = "Module visited link color"; }
+property Color color_module_title { des = "Module title color"; }



Please keep your eye on dw_styles for more posts, including use-questions, tutorials, and calls for all sorts of volunteers. We want your journals to be easy to make pretty and functional.

Comments

[kerri]

The default style - Negatives Black - is the one that I'm using, and I've noticed some weird spacing and things that seem out of alignment for the links below entries. Link is on it's own line, and then there's a double space and then the other links. Is that a change that's supposed to have happened, or a break? I'm sorry if I'm asking an obvious question, I'm just not clear on what's supposed to be affected and what's not.

I see that Custom CSS is going to be available, though, which is awesome :D I am so excited about the things that you guys are doing.

[wistfuljane]

I don't know if this post is the right place to make this suggestion or if I should forward this to the docs team, but for "Entry foreground color" and "Module foreground color", may I suggest adding "text" to it like you have for "Page foreground/text color" under Style > Colors?

[lanterne_rouee]

(this is in negatives black)

it seems like there are black boxes around the words/links under each comment, that are just a teensy bit greater in height than the black background strip of the whole links area under each comment. so, the top of the bar looks uneven. sometimes. it is not consistent. no idea what the difference is from one bar to another.

also, i was looking at a community (dw_suggestions) and i noticed that when there are threads of unexpanded comments, under the first comment and reply all the text is black and the background is black. so, it looks like there are big empty spaces - until you notice the little head icons and realize there are more comments/links there.

[lanterne_rouee]

oh, i forgot to mention, the links to additional comment pages are also blacked out until you hover over them.

[zvi]

Does this entry have an extra <li> or an invisible one, or what?

Also, when opening quickreply, neither my account name nor the picture link are visible, they appear to be black on black until I hover over them, when they turn white.

[aveleh]

I would definitely rather that people ask questions.

Because of changes to core2, putting those links onto two lines was an easy fix for how squished they were looking. So, it is supposed to have happened. However, it's on my list of requests for our CSS gurus to make it look better.

And, yes, I'm so excited too!

[aveleh]

I'll take that report. Thanks! Consistency is definitely something that's important.

[aveleh]

Black boxes: Not in the ticket tracker yet, but it's on my list of things to move in there.

Collapsed comments and page numbers getting lost black text/background: In the ticket tracker. Thanks!

[northern]

Yeah, the links and tag list on the sidebar look really weird, still, even though they're not overlapping anymore as they did before. Also, they disappear partially or completely from sight, seemingly randomly. But I'm sure you've noticed this. :)

[lanterne_rouee]

thank you! :)

just fyi: as i'm writing this, in the links bar at the bottom of your reply, the box around the word reply is dipping below the bar instead of above it.

[northern]

Oh yes, I forgot. I *just* discovered there's a link to "previous *whatever number you set* posts" at the very top, after the bullet point, before the entries start. It's blacked-out, unless you put your mouse on it, which I just did.

What's up with all the bullets everywhere, btw? Seems easier just to skip them and have just the text...

[cimorene]

Great work! Wow, I'm so stoked about how you've renamed the properties so they actually make sense and now the color properties actually say what they do in the names of them! No more trial and error! Seriously. Rock on.

Issue with defautl style text??

[faintdreams]

The text of the 'subscribe' 'notifications' and 'tell a friend' are all missing (or invisible ) under the default journal style..

the icons are present but don't have any descriptive text until a mouse-over occurs.

I can email a screen-shot to someone if that makes what I am describing any clearer.

[rebelsheart]

1) On the quick reply form, the commenter's username appear as black on black.

2) Changing the color for "Module Title" Doesn't seem to affect all modules, just 'Tags' - the only one that links to another page.

3) The 'Entry Link' and 'Entry Title' options in color don't seem to affect anything at all. Ok, that was weird. In the tab I was using to check my changes, nothing happened, but in my original tab all was fine after a refresh - even though I'd refreshed the other tab repeatedly.

[misscake]

In Negatives, the spacing in the bar across the top with "Recent Entries, Archive, Reading...etc." is off. The word Recent is above Entries and is offset (i.e. the R in Recent is above the second e in Entries.

Regarding the Tags page in Negatives Black

[elizabeth_rice]

I hope this is the place to report these problems.

On the Tags page in Negatives Black, the tags aren't visible (black link colour on black background).

[elizabeth_rice]

Sorry, one more thing. Will users have the ability to change the hover link and background colours of their journal style (Negatives Black)?

[trobadora]

Minor thing: The length of usernames in the sidebar still causes a horizontal scroll bar to appear on Negatives pages.

Re: Regarding the Tags page in Negatives Black

[wabbitseason]

I'm having the same problem. Also any "previous page" type links on the main page.

[ninetydegrees]

Thanks for the recap, aveleh!

Little adjustments

[branchandroot]

I'm thinking the userlinks module should also have an on-off switch in options, like the userpic/name/site.

The "action on selected comments" inside .bottomcomment on one's own journal entry pages could also use a tag around the text, so the text, as well as the links, can be manipulated by css. I'd go for a paragraph tag, myself.

Also is page border color going to get a prop? Given that it's one of the simplest ways of making a full-page sidebar background color, that seems like one it might be good to have a way to manipulate.

[turlough]

I don't think anyone's mentioned these yet:
- the navigation links in the sidebar are displayed inline (and so are the action links I notice)
- the calendar in the sidebar is still offset to the right of the rest of the modules
- the "previous xx" link at the top of the sidebar is a little unnecessary now

Re: Little adjustments

[turlough]

I'm thinking the userlinks module should also have an on-off switch in options, like the userpic/name/site.

This, yes, please!

Core Layer Views

[ninetydegrees]

Dunno if I'm doing something wrong but using $p.view == "read" doesn't work. Using $p.view == "friends" does. For info, read is used in function CommentInfo::print_readlink and function CommentInfo::print_postlink().

The definition of view says friends not read: var readonly string view "The view type (recent, friends, archive, month, day, entry)";

[gossymer]

I had a few general questions - I was wondering where we'll be able to have:

For posts
1. username before subject/tite: usually titles don't actually tell you much about the post and some people just don't type a subject title at all. The majority of the time, the username tells you more about what to expect in a post than the title itself
2. date stamp just above the linkbar, maybe right aligned or grey or something - at least for the reading list. The date is usually something we seem to skip to get to the important content - having it closer to the bottom of the post means it doesn't get in the way of finding out what the post is about
3. Behing able to hide certain buttons on our reading list - like "tell a friend" and "add to memories" (especially if we only add to mems after visiting the individual entry page for instance)

For commnts, could we get date after or under username? (perhaps on the right of the username?) and the tracking button after the comment text because people usually track after reading the comment, me thinks >_>

Lastly, where could we direct mockups for styles/alternate site schemes etc? I did a mockup which I posted here, and hope to do a few more different mockups, but I'd like to know where I could direct them ^_^