wyntarvox: (Default)
wyntarvox ([personal profile] wyntarvox) wrote in [site community profile] dw_styles2009-10-14 09:30 pm

Removing lj* classes

There are a still a few CSS classes in core2 that use the lj prefix (ljtaglist, ljedittime, ljuser and ljcmtmanage). [personal profile] foxfirefey and I talked about it briefly in IRC and she mentioned that it had been discussed before, but I think these should be stripped out and replaced with non-site-specific classes.

As far as I understand it, the argument against changing them is that it could mess with users' existing custom CSS, which is definitely a very good point. However, I think given enough warning and follow-up support, we could make this change now without too much disruption. It wouldn't really be that difficult for users who are affected to adjust their CSS to the new version, especially if we're very clear about exactly what changes we're making.

If we want to change them, we're obviously better off doing it sooner rather than later. The longer we leave it, the more users whose custom CSS we may be messing with. Whichever way it goes, I think we need to make a final decision ASAP so we can either get on with fixing it or have a final decision made to not fix it.

Thoughts? Comments? Rotten fruit?
zvi: self-portrait: short, fat, black dyke in bunny slippers (Default)

[personal profile] zvi 2009-10-14 11:27 am (UTC)(link)
I think it's a good idea. LJ-stripping is pretty much a system imperative, and the style system is one of those weirdly user facing parts where it can have long term effects on people who aren't programmers.
kareila: Rosie the Riveter "We Can Do It!" with a DW swirl (dw)

[personal profile] kareila 2009-10-14 12:21 pm (UTC)(link)
There's so much churn going on with styles that things are already breaking for people with pretty much every code push. Better to do it now while we still have the excuse of being in "beta" than to postpone or not do it.
damned_colonial: Convicts in Sydney, being spoken to by a guard/soldier (Default)

[personal profile] damned_colonial 2009-10-14 05:22 pm (UTC)(link)
This. After all, that's what "beta" means.
ninetydegrees: Art: self-portrait (Default)

[personal profile] ninetydegrees 2009-10-14 12:45 pm (UTC)(link)
However, I think given enough warning and follow-up support, we could make this change now without too much disruption.

*nods* Especially if you/someone also posts in non-official layout-related communities.
elizaria: generation kill text foxtrot.uniform.charlie.kilo (misc- colors are pretty)

[personal profile] elizaria 2009-10-14 02:16 pm (UTC)(link)
Yeah, like [personal profile] kareila said, there's so much going on that better now than later.
baggyeyes: Bugs Bunny and the Bull (Default)

[personal profile] baggyeyes 2009-10-14 04:29 pm (UTC)(link)
As everybody else has said, now is definitely better, with people keeping an eye out immediately after a code push on the usual communities [profile] gatting_started, [community profile] style_system, [community profile] dreamwidthlayouts, [community profile] mintyapple...I mention the last two because it might be a good policy for now to see where people are posting their issues. I've seen a couple of style complaints in [profile] gatting_started.
foxfirefey: A headless unicorn from Diesel Sweeties. (headless unicorn)

[personal profile] foxfirefey 2009-10-14 04:59 pm (UTC)(link)
I want these gone so bad. It is like an itch.
delight: (Default)

[personal profile] delight 2009-10-14 05:42 pm (UTC)(link)
+1.

I'd have to rewrite the Core1 layouts I did for a few friends (who wanted Smooth Sailing as the base enough I was happy to mess with it, but didn't have enough free time to rewrite Smooth Sailing -- if anyone has done that, if it's even legal to do that, please tell me!) but I am entirely in agreement with how the lj* classes are as annoying as an unscratchable itch.
kareila: "PERL!" (perl)

[personal profile] kareila 2009-10-18 01:06 pm (UTC)(link)
By the way, there is already a relevant bug open (1389) for removing "LJ" from things. One could simply comment there with a link to this post.