afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] dw_styles2009-04-25 05:20 am

Core1 ported styles reading page problems

So in the latest code push, we fixed an issue where the "friends" terminology was still hanging around, and replaced it with "read". This caused the logic on the reading pages of some ported styles to not work right.

The most common manifestation of this is that usernames of entry posters on the readpage and /network disappear, making the page look like your recent entries page.

Quick fix, look for:

$p.view == "friends".

It may show up also in other forms such as $.view == "friends", or also $p.view != "friends", etc)

Replace that with the relevant line below, including parentheses:

($p.view == "read" or $p.view == "network")
($.view == "read" or $.view == "network")
($p.view != "read" and $p.view != "network")

PS. We also fixed a bunch of Transmogrified issues, including putting the most basic wizard options in -- num_items_reading, num_items_recent, use_journalstyle_entry_page- -, and the huge whitespace after every username in a comment. And [personal profile] av8rmike has been awesome at polishing away some rough spots in the Negatives CSS.

As always, we're working on fixing bugs and improving the style system. No new features until we've reached Open Beta (seven days away!), but once we're safely into Open Beta, we can focus on implementing richer features. Custom text modules come to mind (though we're not stopping there)!

ETA If your style has both, make sure that you edit both your layout layer, and your theme layer
ETA: 2010-09-07: added network
turlough: young man in hideous green-patterned shirt with rised finger, Xander from 'Buffy the Vampire Slayer' ((buffy) excuse me?)

[personal profile] turlough 2009-04-24 09:50 pm (UTC)(link)
We also fixed a bunch of Transmogrified issues [...] the huge whitespace after every username in a comment

It looks like it's still there to me, in this entry for example. I haven't done anything to the s2 code at all and emptying the browser cache doesn't get rid of it. (I'm using Firefox 3.0.8 on Mac OSX 10.4.11)
turlough: purple crocuses ((dw) dreaming of music)

[personal profile] turlough 2009-04-24 09:59 pm (UTC)(link)
I just realised that you probably couldn't. Here's a screencap of what I'm seeing.
turlough: purple crocuses ((mcr) oh shit!)

[personal profile] turlough 2009-04-24 10:09 pm (UTC)(link)
Aha! I've completely missunderstod what this bug's been all along :-)