Core1 ported styles reading page problems

[afuna]

So in the latest code push, we fixed an issue where the "friends" terminology was still hanging around, and replaced it with "read". This caused the logic on the reading pages of some ported styles to not work right.

The most common manifestation of this is that usernames of entry posters on the readpage and /network disappear, making the page look like your recent entries page.

Quick fix, look for:

$p.view == "friends".

It may show up also in other forms such as $.view == "friends", or also $p.view != "friends", etc)

Replace that with the relevant line below, including parentheses:

($p.view == "read" or $p.view == "network")
($.view == "read" or $.view == "network")
($p.view != "read" and $p.view != "network")

PS. We also fixed a bunch of Transmogrified issues, including putting the most basic wizard options in -- num_items_reading, num_items_recent, use_journalstyle_entry_page- -, and the huge whitespace after every username in a comment. And av8rmike has been awesome at polishing away some rough spots in the Negatives CSS.

As always, we're working on fixing bugs and improving the style system. No new features until we've reached Open Beta (seven days away!), but once we're safely into Open Beta, we can focus on implementing richer features. Custom text modules come to mind (though we're not stopping there)!

ETA If your style has both, make sure that you edit both your layout layer, and your theme layer
ETA: 2010-09-07: added network

Comments

[karen2205]

Repeating a comment I left on dw_maintenance, in case this is a better place for it.

I was using Zesty White (which I believe is Core 2) and following the code change usernames were displaying fine, but the names of communities weren't displaying so instead of saying mark wrote in dw_maintenance, it just said "mark wrote under $list of tags" making it appear as if entries in communities were actually entries in personal journals, which is a bit confusing.

I have swapped to using transmogrified because I couldn't work out how to implement the change you're suggesting above - I could get to the advanced customisation area, but couldn't see any layout code that I could alter which I suspect is because Zesty White is a Core 2 style.

[afuna]

Thanks for the report! I've put in a fix for this; will go out soon.

(The lack of the editable code thing is because you're using the system-wide/shared/public code from Zesty, so you'd need to create a theme layer to override, etc, instead of editing. Instructions above more or less assume someone creating a personal copy of a layout, for porting)