Core1 ported styles reading page problems

[afuna]

So in the latest code push, we fixed an issue where the "friends" terminology was still hanging around, and replaced it with "read". This caused the logic on the reading pages of some ported styles to not work right.

The most common manifestation of this is that usernames of entry posters on the readpage and /network disappear, making the page look like your recent entries page.

Quick fix, look for:

$p.view == "friends".

It may show up also in other forms such as $.view == "friends", or also $p.view != "friends", etc)

Replace that with the relevant line below, including parentheses:

($p.view == "read" or $p.view == "network")
($.view == "read" or $.view == "network")
($p.view != "read" and $p.view != "network")

PS. We also fixed a bunch of Transmogrified issues, including putting the most basic wizard options in -- num_items_reading, num_items_recent, use_journalstyle_entry_page- -, and the huge whitespace after every username in a comment. And av8rmike has been awesome at polishing away some rough spots in the Negatives CSS.

As always, we're working on fixing bugs and improving the style system. No new features until we've reached Open Beta (seven days away!), but once we're safely into Open Beta, we can focus on implementing richer features. Custom text modules come to mind (though we're not stopping there)!

ETA If your style has both, make sure that you edit both your layout layer, and your theme layer
ETA: 2010-09-07: added network

Comments

[afuna]

Hm, no that's okay! Or should be at least. Are you having any problems with posters' names on your read page?

[mrsdarcy]

The names are displayed. The issue is that the userinfo icons I replaced aren't displayed for journal names on my reading page. Individual journals and feed accounts get the standard deewee icons. When someone posts in a community the poster gets the standard deewee icon but the comm the community icon I specified. I don't think the replacement code is at fault because it works within entries, just not the entry info.

[afuna]

V. belatedly, try changing this:

<a href="$url/">$e.poster</a>

To this:

$e.poster

(The $e.poster bit already takes care of the link)

[mrsdarcy]

Thank you so much! ♥

[afuna]

You're very welcome!