Core1 ported styles reading page problems

[afuna]

So in the latest code push, we fixed an issue where the "friends" terminology was still hanging around, and replaced it with "read". This caused the logic on the reading pages of some ported styles to not work right.

The most common manifestation of this is that usernames of entry posters on the readpage and /network disappear, making the page look like your recent entries page.

Quick fix, look for:

$p.view == "friends".

It may show up also in other forms such as $.view == "friends", or also $p.view != "friends", etc)

Replace that with the relevant line below, including parentheses:

($p.view == "read" or $p.view == "network")
($.view == "read" or $.view == "network")
($p.view != "read" and $p.view != "network")

PS. We also fixed a bunch of Transmogrified issues, including putting the most basic wizard options in -- num_items_reading, num_items_recent, use_journalstyle_entry_page- -, and the huge whitespace after every username in a comment. And av8rmike has been awesome at polishing away some rough spots in the Negatives CSS.

As always, we're working on fixing bugs and improving the style system. No new features until we've reached Open Beta (seven days away!), but once we're safely into Open Beta, we can focus on implementing richer features. Custom text modules come to mind (though we're not stopping there)!

ETA If your style has both, make sure that you edit both your layout layer, and your theme layer
ETA: 2010-09-07: added network

Comments

[afuna]

Okay, these changes are to the Flexible Squares layout.

For the subject, look for this code:
<div class="subject">"""; if ($e.security != "") { $e.security_icon->print(); } """ $e.subject   </div>

And replace it with this:

<div class="subject">"""; if ($e.security != "") { $e.security_icon->print(); } print $e->formatted_subject({ "" => "" }); """   </div>

And then, anywhere you can find a:

$p.view == "read"


change it to:
$p.view == "read" or $p.view == "network"


So, for example:

$p.view == "read" or $p.view == "entry"

becomes:

$p.view == "read" or $p.view == "network" or $p.view == "entry"


Holler if you get stuck! Also, I hope you don't mind my saying so, but that header is just gorgeous :)

[elrhiarhodan]

Thank you again - everything worked beautifully.

I have a number of friends who are coming on board with DW, does the latest build for the flexible squares layer have the current requirements or will I have to implement these changes on their FS layer, too?

[fu]

Hmmm, I'm almost certain that you'll have to make the changes for each layer.

[citymusings]

Thank you for posting this. I was having the same problem and this fixed it beautifully!