Core1 ported styles reading page problems

[afuna]

So in the latest code push, we fixed an issue where the "friends" terminology was still hanging around, and replaced it with "read". This caused the logic on the reading pages of some ported styles to not work right.

The most common manifestation of this is that usernames of entry posters on the readpage and /network disappear, making the page look like your recent entries page.

Quick fix, look for:

$p.view == "friends".

It may show up also in other forms such as $.view == "friends", or also $p.view != "friends", etc)

Replace that with the relevant line below, including parentheses:

($p.view == "read" or $p.view == "network")
($.view == "read" or $.view == "network")
($p.view != "read" and $p.view != "network")

PS. We also fixed a bunch of Transmogrified issues, including putting the most basic wizard options in -- num_items_reading, num_items_recent, use_journalstyle_entry_page- -, and the huge whitespace after every username in a comment. And av8rmike has been awesome at polishing away some rough spots in the Negatives CSS.

As always, we're working on fixing bugs and improving the style system. No new features until we've reached Open Beta (seven days away!), but once we're safely into Open Beta, we can focus on implementing richer features. Custom text modules come to mind (though we're not stopping there)!

ETA If your style has both, make sure that you edit both your layout layer, and your theme layer
ETA: 2010-09-07: added network

Comments

[anotherslashfan]

thanks for the fix, worked like a charm!

[stormy]

Thanks for the tip! That was driving me crazy!

[gelydh]

Thank you so much for this!

[jeeps]

ugh, you are a living miracle. that was driving me bonkers.

[karanguni]

You are my saviour!

[carolyn_claire]

Thank you!

[pursuing]

This was driving me nuts all night. Thank you so much! ♥

[peaceowl]

hm, the fix didn't work for me! it made usernames show, but above the entries instead of to the side where they should be, and it made my friends page 'ugly', with a strange blue background above each entry. does anyone have any suggestions? if so, thank you in advance!

[liv]

Related fix, which I'm reporting here, but I can do something more formal if it would help:

I was helping a friend who has a Core1 based layout. In her navigation menu, her link to the network was showing up as "Unknown view", and she was unable to change that. The fix uses an odd combination of calling the page "network" and calling it "friendsfriends".

I had to add to the lang_viewname fucntion:
if ($viewid == "network") { return $*text_view_friendsfriends; }

I know we're not really updating Core1, but perhaps it's worth adding this information to this post, which is linked from a Site Issues FAQ so people may come looking here? Alternatively, perhaps it is worth going a bit further in making Core1 compliant with DW's friends-free notation, because I don't think that would break any existing layouts.

Question

[bethmccombs]

Being new to Dreamwidth, I'm not certain if this is the correct place to ask this question. If I'm in the wrong spot, please let me know. When I imported Flexible Squares here for my layout, added the fix for the display name on the friends page, but then discovered the same problem - the lack of usernames - on the "network" page. Is there a way to correct this so the usernames show up on that page?

Thanks,
Beth

[foxfirefey]

Hmm, do you think we might want to parenthetical the network ones?

[roadie]

Thank you. That was really helpful.

Just hope someone's tracking this post...

[liv]

http://www.dreamwidth.org/support/see_request?id=7133

One of the recent crop of LJ refugees has pulled up a new problem: most LJ layouts now have a function called "print_raw" which basically makes that link bar of "share this" buttons. As a result, LJ layouts won't compile under DW's S2 Core1. I could fix this by adding a line to our Core1 which at least defines print_raw (I suggest defining it as an empty function.) Or we could add a note to this post / the FAQ saying "delete anything that says $link->print_raw(); What do you reckon?

[karel]

Eee, thank you so much for this fix! This was driving me crazy, having to hover for the popup and then having to play "guess the community."

[mrsdarcy]

I don't know whether you can help me with this. I have "friends" inside a function (in Opal) and don't know how to get rid of it.

function FriendsPage::lay_make_username (Entry e) {
var Friend f = $.friends{$e.journal.username};
var string url = $e.poster->base_url();
"""

$e.poster""";
if(not $e.poster->equals($e.journal)) {
""" @ $e.journal""";
}
"""

""";
}

[dee_groovy]

It worked! I'm using Flexible Squares, and it worked like a charm - thanks!

[dee_groovy]

Hello,

I have a question - while the usernames show up on the reading page, if it is a community, the community name doesn't show up; only the username. Is there a fix for this as well?

Thanks so much in advance!

[elrhiarhodan]

Seriously late to the party, but this fixed both the missing user and community name as well as a layout problem I was having (the userpics on my reading pane were pushed all the way over to the left).

Thank you!

[krissasaur]

i dont understand what im supposed to do with this.. sorry im so dumb... D:

[sheepy]

Fix didn't work for me, but it's doing weird things with the userpics, so it may just be the layout I chose. Looks fine here, but when you go to the read page, look what happens to the userpics. Any ideas on how to fix this?

[duck]

Thank you so much! This let me use a Generator layout correctly :D