Upcoming Bug Fixes Not Yet Live

[av8rmike]

Since it's been quiet around here lately, afuna asked me to look through the change log and compile a list of bug fixes since the last major code push. As mark posted, there will be a major code push tonight, which should include all of these styles-related issues:

Page Summary module no longer displays "0 comments" when no comments present. [Bug 1312]

View name added to CSS class of navigation links. [Bug 1329]

Fixed "growing text" and other text size problems in Negatives. [Bug 1303]

Fixed collapsing sidebar padding when hovering over Negatives sidebar icon. [Bug 1125]

Fixed behavior of "View in my style/original style" toggle in navigation strip. [Bug 1018]

Color picker window on customize/options.bml now initializes to correct color. [Bug 1263]

Custom colors have been added to journal styles. [Bug 1282]

"parent" CSS class in comment links has been renamed to "commentparent". [Bug 975]

"day-date" CSS class added to date header on Day Page. [Bug 1359]

"first-item" CSS class added to management and interaction links. [Bug 997]

Appending "?style=light" to a journal page URL now works the same as appending "?format=light". [Bug 586]

Transmogrified fixes: Fixed icon overlapping user name in Reply Page [Bug 1342], the Reply Page text area going behind the sidebar [Bug 967], and margin width problems. [Bug 1311]

Clicking "Save and Compile" in the S2 layer editor window will remember your cursor position and return you to it when the page refreshes. [Bug 401]

Fixed a div on the DayPage in Core2 that defined more than one CSS ID. [Bug 1262]

Other Negatives fixes: Removed some old browser hack code [Bug 1360], fixed the display of the calendar in the sidebar [Bug 806], and fixed some padding and placement issues with navigation lists. [Bug 1327]

Finally, a link to the "Advanced Customization" page was added to the "Customize Journal Style" page. [Bug 1182]

A few other Styles-related news items: We're still soliciting themes for Tabula Rasa to be added as official Dreamwidth styles. Directions are in the linked post. Interested in creating a theme, but don't have a reliable method to test your code, or just don't want to mess about with test journals? The Styles team is working on a "style kit", a downloadable set of pages to which you can apply your stylesheet locally, rather than needing to constantly refresh your browser window. You can read more about it here!

qilin has posted this wonderful guide to filtering certain posts on your Reading page through pure CSS classes. Check it out!

If people are looking for other ways to help out, foxfirefey is looking for some volunteers to work on Styles documentation for the DW wiki.
EDIT: Forgot the link!

That should be all for now, but if I've forgotten anything or you have any questions, please leave a comment!

Comments

[torachan]

I am still having problems with Transmogrified and the box going behind the sidebar.

Here's a picture. As with before, this only happens on the actual reply page. If I'm using the quick reply box, it is the correct width.

[av8rmike]

That should definitely not be happening, and doesn't on my own journal. Can you tell me which journal this is?

[torachan]

It's oyceter. I just checked out your journal and yours is working fine for me.

[av8rmike]

S/he is using a custom layout, so the change wouldn't be propagated to that journal.

[torachan]

Oh, okay. :-/ I think I saw it on someone else's, too, but that may have been custom as well.

[ninetydegrees]

I don't know if it's the right place to ask this so feel free to redirect me to another comm.

May I ask what is the reasoning for adding /n at the end of various unordered lists (in the Core layer)?

I'm thinking of print_interaction_links, print_module_list and print_management_links for example.

When the lists are displayed inline it causes a blank space to be displayed between the <li>s. I'm styling some of these lists as tabs in Transmogrified and I have to edit the functions to remove the space instead of simply using CSS. I guess I could use negative margins but I really don't want to. ;)

[av8rmike]

Here's as good a place as any. I knew we put line breaks in the lists for a reason, but it took me a bit of time to hunt it down. If I'm remembering correctly, we wanted a space in between the elements because they wouldn't wrap properly when inlining them.

[ninetydegrees]

A very good reason, then, and not a problem since free users can have layers. Thanks a lot for taking the time to find this bug.

[ninetydegrees]

Another question if you don't mind: the way the Core is coded, some things get printed even if they're empty (the div for userpics, the span for entry posters, etc.) which can make styling a bit difficult. Would you explain why, please? I want to suggest adding a body class for account type at suggestions and I need to explain why I think it could be useful.

[av8rmike]

Well, I see your suggestion for the first part of your question is already entered into Bugzilla, and we're still talking about how best to implement that.
I don't understand what that part about the body class has to do with it.

[ninetydegrees]

Er, this has nothing to do with my previous suggestion. I'm making a theme for Tabula Rasa and I want to display a border below entry-poster when the poster name is actually printed but not when it isn't. I can add .page-read to fix the problem on personal journals but that also removes it from page-recent on communities. If there was a body class called account-type-xxx I could do that. Or I could suggest styling elements be only printed where there is an element to style but I assumed there was a good reason they always were hence my comment.